[BTAPP-57] Add Android native-code compile gate to app CI

chris commented

2026-08-30 18:54:56 -06:00

Owner

Ticket

BTAPP-57 Compile the Android native code in CI

Summary

Adds an android job to .forgejo/workflows/app.yml, parallel to the existing check job, path-filtered the same way (app/**)
Regenerates the gitignored android/ project per-run via bunx expo prebuild --platform android --no-install (no npm dependency), installs JDK 17 via actions/setup-java@v4, and compiles the hand-written Kotlin in app/modules/notification-doorbell plus merges its manifest via ./gradlew :notification-doorbell:assembleDebug :app:processDebugMainManifest — the fast pair, not a full assembleDebug
Android SDK cmdline-tools are installed via plain shell (curl + unzip of a pinned commandlinetools-linux-11076708_latest.zip, then sdkmanager --licenses), not android-actions/setup-android@v3 as originally planned — that action isn't in this Forgejo instance's action mirror (data.forgejo.org) and 404s. See docs/CI.md for the corrected explanation of how this instance resolves third-party actions.
A stub google-services.json (package name only, no real credentials) stands in for the real gitignored file, avoiding a CI secret
~/.gradle + ~/android-sdk are cached alongside the existing ~/.bun/install/cache entry
Documents the new job in docs/CI.md, including the corrected action-mirror note above
This is a compile gate, not a test gate — no Kotlin unit tests are added (out of scope per the ticket)

Verification

Red/green proof observed directly on this PR, via a temporary probe commit that introduced a deliberate Kotlin syntax error under app/modules/notification-doorbell/android/src/main/java/com/budgettracker/doorbell/Doorbell.kt, confirmed against the raw runner log (not just the surface-level pass/fail status) for both ends:
- Red: with the syntax error in place, the android job failed with e: .../Doorbell.kt:283:40 Syntax error: Expecting '"'. / BUILD FAILED in 1m 2s — after successfully getting through checkout, bun install, JDK setup, SDK cmdline-tools install, and license acceptance, i.e. failing for the right reason and not some earlier toolchain gap.
- Green: after reverting the probe, the android job passed cleanly — BUILD SUCCESSFUL in 2m 19s, 144 actionable tasks: 143 executed, 1 up-to-date, total job wall time ~2m48s (Gradle/SDK cache warm from the preceding run).
- Along the way, pinning the newest cmdline-tools build (v23.0/16111833) turned out to regress sdkmanager --licenses into a silent no-op (replaced by a new android CLI), causing a LicenceNotAcceptedException unrelated to the probe — caught the same way (raw log, not just status) and fixed by pinning the long-stable build 11076708 (v11.0) instead.
- Mid-verification, this Forgejo instance's pull_request-triggered Actions run creation stalled for several pushes on this PR (webhook/post-receive succeeded each time, but no run was ever created). Restarting the forgejo-runner container had no effect; restarting the main forgejo container also did not restore the pull_request trigger path (still not firing as of this PR), but it did NOT lose the underlying data or affect the runner's ability to execute jobs — dispatching the workflow manually (POST .../actions/workflows/app.yml/dispatches, workflow_dispatch event) against this PR's exact head commit worked immediately and is what produced the red/green proof above (tasks 337/339/341 = pull_request-triggered before the stall; 343/345 = workflow_dispatch after it). The pull_request/push trigger stall on this Forgejo instance is still open and unrelated to this ticket's code — worth its own follow-up investigation/ticket; branch protection and normal PR checks will not run until it's fixed.

## Ticket [BTAPP-57](http://192.168.2.100:7123/home/browse/BTAPP-57/) Compile the Android native code in CI ## Summary - Adds an `android` job to `.forgejo/workflows/app.yml`, parallel to the existing `check` job, path-filtered the same way (`app/**`) - Regenerates the gitignored `android/` project per-run via `bunx expo prebuild --platform android --no-install` (no npm dependency), installs JDK 17 via `actions/setup-java@v4`, and compiles the hand-written Kotlin in `app/modules/notification-doorbell` plus merges its manifest via `./gradlew :notification-doorbell:assembleDebug :app:processDebugMainManifest` — the fast pair, not a full `assembleDebug` - Android SDK cmdline-tools are installed via plain shell (`curl` + `unzip` of a pinned `commandlinetools-linux-11076708_latest.zip`, then `sdkmanager --licenses`), **not** `android-actions/setup-android@v3` as originally planned — that action isn't in this Forgejo instance's action mirror (`data.forgejo.org`) and 404s. See `docs/CI.md` for the corrected explanation of how this instance resolves third-party actions. - A stub `google-services.json` (package name only, no real credentials) stands in for the real gitignored file, avoiding a CI secret - `~/.gradle` + `~/android-sdk` are cached alongside the existing `~/.bun/install/cache` entry - Documents the new job in `docs/CI.md`, including the corrected action-mirror note above - This is a compile gate, not a test gate — no Kotlin unit tests are added (out of scope per the ticket) ## Verification - [x] **Red/green proof observed directly on this PR**, via a temporary probe commit that introduced a deliberate Kotlin syntax error under `app/modules/notification-doorbell/android/src/main/java/com/budgettracker/doorbell/Doorbell.kt`, confirmed against the raw runner log (not just the surface-level pass/fail status) for both ends: - **Red**: with the syntax error in place, the `android` job failed with `e: .../Doorbell.kt:283:40 Syntax error: Expecting '"'.` / `BUILD FAILED in 1m 2s` — after successfully getting through checkout, bun install, JDK setup, SDK cmdline-tools install, and license acceptance, i.e. failing for the right reason and not some earlier toolchain gap. - **Green**: after reverting the probe, the `android` job passed cleanly — `BUILD SUCCESSFUL in 2m 19s`, `144 actionable tasks: 143 executed, 1 up-to-date`, total job wall time **~2m48s** (Gradle/SDK cache warm from the preceding run). - Along the way, pinning the *newest* cmdline-tools build (v23.0/16111833) turned out to regress `sdkmanager --licenses` into a silent no-op (replaced by a new `android` CLI), causing a `LicenceNotAcceptedException` unrelated to the probe — caught the same way (raw log, not just status) and fixed by pinning the long-stable build 11076708 (v11.0) instead. - Mid-verification, this Forgejo instance's `pull_request`-triggered Actions run creation stalled for several pushes on this PR (webhook/post-receive succeeded each time, but no run was ever created). Restarting the `forgejo-runner` container had no effect; restarting the main `forgejo` container also did not restore the `pull_request` trigger path (still not firing as of this PR), but it did NOT lose the underlying data or affect the runner's ability to execute jobs — dispatching the workflow manually (`POST .../actions/workflows/app.yml/dispatches`, `workflow_dispatch` event) against this PR's exact head commit worked immediately and is what produced the red/green proof above (tasks 337/339/341 = pull_request-triggered before the stall; 343/345 = workflow_dispatch after it). **The `pull_request`/`push` trigger stall on this Forgejo instance is still open and unrelated to this ticket's code** — worth its own follow-up investigation/ticket; branch protection and normal PR checks will not run until it's fixed.

chris added 3 commits

2026-08-30 18:54:56 -06:00

[BTAPP-57] Add Android native-code compile gate to app CI. b345208b1a

[BTAPP-57] Probe: introduce a deliberate Kotlin syntax error to verify the android CI job fails. f32e71ec77

Revert "[BTAPP-57] Probe: introduce a deliberate Kotlin syntax error to verify the android CI job fails." 05cda87d9c