[BTAPI-81] Add a feature flag to gate the wealthsimple-api migration cutover #91

Merged

chris merged 10 commits from feature/BTAPI-81 into main

2026-09-13 16:50:04 -06:00

chris commented

2026-09-13 16:01:05 -06:00

Owner

Ticket

BTAPI-81 — Add a feature flag to gate the wealthsimple-api migration cutover

Summary

Adds Config.wealthsimpleApiEnabled (env WS_API_ENABLED, default false), the flag that gates the whole wealthsimple-api migration cutover — the client swap (BTAPI-75), doorbell delegation (BTAPI-76), and status sourcing (BTAPI-77).
No behavior of its own: nothing reads the flag yet, so false keeps today's direct-Wealthsimple / local-session path untouched. BTAPI-75/76/77 each add the branch point that consumes it.
Documents the flag's lifecycle in server/lib/wealthsimple/CLAUDE.md, including two things a later implementer would otherwise hit blind: the three consumers do not share a network (sync is not on api-shared, so BTAPI-75 carries an infra prerequisite this ticket deliberately does not resolve), and BTAPI-78 retires the flag with the local credentials deleted last so the rollback path survives.
Documents WS_API_ENABLED=false in .env.example, with the caveat that flipping it needs the container recreated, not merely restarted — compose resolves env_file at creation.
Tests: the code default and the shipped .env.example value are both asserted.

Verification

bun --cwd=./server run verify — type-check, lint, format, format:check all pass; tests 773 passed / 1 skipped / 1 failed. The single failure is lib/wealthsimple/trigger-listener/.test.ts:97 binding port 9998 → EADDRINUSE, which is environmental and pre-existing (reproduced on main with this branch absent; the port is held by the host's stash container at 0.0.0.0:9998->9999/tcp, and the file is 9/9 green with WS_SYNC_TRIGGER_PORT=19998). It does not reproduce in CI.

🤖 Generated with Claude Code

## Ticket BTAPI-81 — Add a feature flag to gate the wealthsimple-api migration cutover ## Summary - Adds `Config.wealthsimpleApiEnabled` (env `WS_API_ENABLED`, default `false`), the flag that gates the whole wealthsimple-api migration cutover — the client swap (BTAPI-75), doorbell delegation (BTAPI-76), and status sourcing (BTAPI-77). - No behavior of its own: nothing reads the flag yet, so `false` keeps today's direct-Wealthsimple / local-session path untouched. BTAPI-75/76/77 each add the branch point that consumes it. - Documents the flag's lifecycle in `server/lib/wealthsimple/CLAUDE.md`, including two things a later implementer would otherwise hit blind: the three consumers do not share a network (`sync` is not on `api-shared`, so BTAPI-75 carries an infra prerequisite this ticket deliberately does not resolve), and BTAPI-78 retires the flag with the local credentials deleted last so the rollback path survives. - Documents `WS_API_ENABLED=false` in `.env.example`, with the caveat that flipping it needs the container **recreated**, not merely restarted — compose resolves `env_file` at creation. - Tests: the code default and the shipped `.env.example` value are both asserted. ## Verification `bun --cwd=./server run verify` — type-check, lint, format, format:check all pass; tests 773 passed / 1 skipped / 1 failed. The single failure is `lib/wealthsimple/trigger-listener/.test.ts:97` binding port 9998 → `EADDRINUSE`, which is environmental and pre-existing (reproduced on `main` with this branch absent; the port is held by the host's `stash` container at `0.0.0.0:9998->9999/tcp`, and the file is 9/9 green with `WS_SYNC_TRIGGER_PORT=19998`). It does not reproduce in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

chris added 10 commits

2026-09-13 16:01:05 -06:00

[BTAPI-81] Add WS_API_ENABLED flag to gate the wealthsimple-api cutover. 3d5da72449

[BTAPI-81] Document the WS_API_ENABLED cutover flag lifecycle. f617147edc

[BTAPI-81] Record that the three flag consumers do not share a network. 4dee2ea9dd

[BTAPI-81] Fix the retirement comment to count all three branches. 672c62223b

[BTAPI-81] Correct the flag flip to require container recreation. f19091aa9d

[BTAPI-81] Note that the client URL and key do not exist yet. 345124ba7a

[BTAPI-81] Assert .env.example ships the flag as false. 1a9d6f7075

[BTAPI-81] Drop the dangling "below" from the flag comment. 7224b61067

[BTAPI-81] Correct why the template flip escapes the default test. ee15bc894f

[BTAPI-81] Compress the migration flag section of the wealthsimple CLAUDE.md.