chris/irrigo
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Activity Actions

[IRRIGOAPP-109] Replace in-app alert UI with Android system notifications #10

Open
chris wants to merge 2 commits from feature/IRRIGOAPP-109 into main
pull from: feature/IRRIGOAPP-109
merge into: chris:main
Conversation 0 Commits 2 Files changed 5 +22 -442
chris commented 2026-07-05 11:23:50 -06:00
Owner
Copy link

Ticket

IRRIGOAPP-109 Replace in-app alert UI with Android system notifications

Summary

  • Changed setNotificationHandler in NotificationsBridge to set all shouldShow* flags to true, so foreground pushes now surface as standard Android system banners instead of being suppressed
  • Removed the in-app PushBanner overlay, its state, and the addNotificationReceivedListener wiring that drove it
  • Kept addNotificationResponseReceivedListener for deep-link routing when the user taps a system notification
  • Deleted the PushBanner component and its tests (5 tests removed, component fully retired)
## Ticket [IRRIGOAPP-109](http://192.168.2.100:7123/home/browse/IRRIGOAPP-109/) Replace in-app alert UI with Android system notifications ## Summary - Changed `setNotificationHandler` in `NotificationsBridge` to set all `shouldShow*` flags to `true`, so foreground pushes now surface as standard Android system banners instead of being suppressed - Removed the in-app `PushBanner` overlay, its state, and the `addNotificationReceivedListener` wiring that drove it - Kept `addNotificationResponseReceivedListener` for deep-link routing when the user taps a system notification - Deleted the `PushBanner` component and its tests (5 tests removed, component fully retired)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/IRRIGOAPP-109:feature/IRRIGOAPP-109
git switch feature/IRRIGOAPP-109

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff feature/IRRIGOAPP-109
git switch feature/IRRIGOAPP-109
git rebase main
git switch main
git merge --ff-only feature/IRRIGOAPP-109
git switch feature/IRRIGOAPP-109
git rebase main
git switch main
git merge --no-ff feature/IRRIGOAPP-109
git switch main
git merge --squash feature/IRRIGOAPP-109
git switch main
git merge --ff-only feature/IRRIGOAPP-109
git switch main
git merge feature/IRRIGOAPP-109
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
chris/irrigo!10
No description provided.